#48146 async simple paged results issue
Closed: wontfix Opened by nhosoi.

Problem scenario:
1) Send a simple paged results search requests asynchronously.
2) Repeat the request with the same cookie before the first request is returned.
3) The intenal search result object held by the thread for the second request could be destroyed when the first request completes.


With the patch: 0001-Ticket-48146-async-simple-paged-results-issue.patch
1) Passed 40 hour stress test
2) Passed acceptance tests

Thanks to Rich and Mark for their discussions and reviews.

Pushed to master:
19d8b63..947477f master -> master
commit 947477f2e2367337a8c220d8c9d03a62bf1bbf1c

Pushed to 389-ds-base-1.3.3:
1dbce48..ec8801a 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit ec8801a69adbe2f502513fabcbb79bc5e38bf197

Pushed to 389-ds-base-1.3.2:
422c9cd..c4ab119 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit c4ab1196a597ff6845535cf5068be7c5524ec0cb

Pushed to 389-ds-base-1.2.11:
8d46178..31cd2a5 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 31cd2a52cc6a8b73a26016a0e1e6910c265a44d7

git patch file (master) -- log pr index in access log
0001-Ticket-48146-async-simple-paged-results-issue-log-pr.patch

git patch file (master) -- need to close a small window for a pr index competed among multiple threads
0001-Ticket-48146-async-simple-paged-results-issue-need-t.patch

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-log-pr.patch​ added
git patch file (master) -- log pr index in access log

ack

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-need-t.patch​ added
This scares me - if it is somehow possible to deref the 0x1 pointer, boom - crash.

Replying to [comment:9 rmeggins]:

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-log-pr.patch​ added
git patch file (master) -- log pr index in access log

ack

Attachment 0001-Ticket-48146-async-simple-paged-results-issue-need-t.patch​ added
This scares me - if it is somehow possible to deref the 0x1 pointer, boom - crash.

Understood... How about the next patch? I'm running the test with it now...

git patch file (master) -- revised patch for "need to close a small window for a pr index competed among multiple threads"
0001-Ticket-48146-async-simple-paged-results-issue-need-t.2.patch

Rich, thank you for reviewing the patches!

Pushed to 389-ds-base-1.3.3:
650ca94..8e21bfb 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit 9eb20d89755160aa916544c7cfce0ad066e538f7
commit 3cf85d1ad6cbc0feac5578dee5ce259c0f65055f
commit 8e21bfbe4fcac79cf39e5c6b579c4bc88e05257e

Pushed to 389-ds-base-1.3.2:
c4ab119..644a116 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit b123fae0fbf2b9125c574abf2d5a635f08716210
commit 85d105ebca073056dc83f7b6657d2605a4b6a162
commit 644a116950d34bd11533a4426f6af6953865edf2

Pushed to 389-ds-base-1.2.11:
31cd2a5..82020ad 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 0bff700c0a50f26819f203772085e440a1fa8c23
commit 38efd1712dc650ccc09942efad80e52f1bc32318
commit 82020ad65cf1b1762a8e9eaaf1a9cd7bc7b709f1

Closing this ticket when the patches are pushed to the master branch.

Pushed to master:
cd9afbb..4051fe0 master -> master
commit 09c730bec94bfd5f40f46da467a93768ced061f6
commit 5e9c4f1f09596dd076a6c3a0bb419580e8fd705e
commit 4051fe0eba4128bae88fecfbf2c9441aeb334796

git patch file (master) -- fixing a regression introduced by the previous commit
0001-Ticket-48146-async-simple-paged-results-issue.2.patch

Reviewed by Mark (Thank you!!!)

Pushed to master:
eb46e6f..bd2c0d0 master -> master
commit bd2c0d0b6a499d7f91a36e8a9feb83e4fbd3dac5

Pushed to 389-ds-base-1.3.3:
03bee0a..0c7b38a 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit 0c7b38abfb4c5c02286efd5e698616534a798993

Pushed to 389-ds-base-1.3.2:
46242d8..2003d79 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit 2003d79eb3fbd3850c9a2590c65fbe146e96853d

Pushed to 389-ds-base-1.2.11:
164cb24..52a7299 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 52a7299d243278de0e1877714f5ff65a5c542b5e

git patch file (master) -- fixing a regression introduced by the commit 5e9c4f1f09596dd076a6c3a0bb419580e8fd705e
0001-Ticket-48146-async-simple-paged-results-issue.3.patch

Reviewed by Mark (Thank you!!)

Pushed to master:
bd2c0d0..03d3455 master -> master
commit 03d3455dfbe84f034a234df2ebd8cfdd7ad15f48

Pushed to 389-ds-base-1.3.3:
0c7b38a..f6fe5bf 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit f6fe5bfe4c1fb1402af789a0f935c765c299d103

Pushed to 389-ds-base-1.3.2:
2003d79..64b54d4 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
commit 64b54d416e75eaeb611ece982c1be9acf3f56161

Pushed to 389-ds-base-1.2.11:
52a7299..b500958 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit b50095835b1889f8578ea3da579b543ed1619885

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1228823

Metadata Update from @nhosoi:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.2.11.33

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1477

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)