389-ds-base

#49345 remove dead code: dblayer_flush
Closed: wontfix by mreynolds. Opened by lkrispen.

Closed: wontfix
Reopen Issue

the dblayer_flush() is a noop, and the corresponding function in ldif_back_ldbm also does nothing:

 /*
  *  Function: ldif_back_flush 
  * Description: does nothing
 */
void
ldif_back_flush(Slapi_PBlock *pb)
{
    slapi_log_err(SLAPI_LOG_TRACE, "ldif backend flushing\n", 0, 0, 0);
    slapi_log_err(SLAPI_LOG_TRACE, "ldif backend done flushing\n", 0, 0, 0);
    return;
}

and 

int
dblayer_flush(struct ldbminfo *li __attribute__((unused)))
{
    return 0;
}

the only effect is that in the houskeeping thread we regularily iterate over all backends to find and call a function which does nothing

0001-Ticket-49445-remove-dead-code.patch

Metadata Update from @lkrispen:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

@mreynolds I don't know since when dblayer_flush is a noop, but it was like this already in 1.2.11 and I don't know hpw to check earlier versions

@mreynolds I don't know since when dblayer_flush is a noop, but it was like this already in 1.2.11 and I don't know hpw to check earlier versions

Okay, in that case I'm okay with the fix. But, if there was code in that function in 1.3.4 then I would be more concerned. So Ack!

Metadata Update from @mreynolds:
- Custom field reviewstatus adjusted to ack (was: None)

Metadata Update from @lkrispen:
- Issue assigned to lkrispen

Metadata Update from @mreynolds:
- Issue set to the milestone: 1.3.7 backlog

Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2404

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)
Metadata
None
None
None
None
ack
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.