Fedora-app

#57 Add type annotations where necessary
Merged by a2batic. Opened by amitosh.
amitosh/Fedora-app tsify  into  master

Download 57.patch

Closes #56

Blocked by #55

~~This PR contains code that is in #55 , this needs to be rebased before it can be merged.~~

Rebased. Good to go!
Edited by amitosh

1 new commit added

  • Use Observables instead of Promises to match with Angular API

rebased onto ffcbf838f0469a328fcbcb542c1d605bd94d1ab6

3 new commits added

  • Fix TS lint errors
  • Use Observables instead of Promises to match with Angular API
  • Add type declarations to Http and Social providers

1 new commit added

  • Add documentation to providers and pages

Shouldnt it be containing all the pages ?

+1

@amitosh Ionic serve is throwing following error :-

[10:40:19]  typescript: src/app/main.ts, line: 2 
            Cannot find module '@environment'. 
       L1:  import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
       L2:  import ENV from '@environment';
       L3:  import { AppModule } from './app.module';
[10:40:19]  typescript: src/providers/social/facebook.ts, line: 3 
            Cannot find module '@environment'. 
       L2:  import 'rxjs/add/operator/map';
       L3:  import ENV from '@environment';
       L4:  import { Facebook } from 'fb';
[10:40:19]  typescript: src/providers/social/twitter.ts, line: 8 
            Cannot find module '@environment'. 
       L7:  import { Observable } from 'rxjs/Observable';
       L8:  import ENV from '@environment';

@a2batic The tree shows all pages are added: https://pagure.io/fork/amitosh/Fedora-app/blob/tsify/f/src/app/app.component.ts

There must be some error in rendering the diff at Pagure

LGTM, @amitosh, please rebase the PR.

rebased onto 824f8c35ef8d43c4bbfdc89ed068799e37079c9b

Merging.

Pull-Request has been merged by a2batic
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.