Changes the primary navigation of application to a bottom bar tabs based layout. Also Updates The design of the home page to the finalised new style (https://marvelapp.com/8j6ihg7)
Closes - #23: Landing page for the application - #12 Fetch Fedora magazine images from API - #28 Navigation Fixes
Is it necessary to inline them? Webpack does the inlining and other performance hacks automatically. Inline will make it difficult to edit when needed.
Not required. We can directly use MorePage
Not required. See above
Debugging remnant?
I would ask you to hold on this feature. It is easier and more scalable to extend the FedoraMagazineProvider into a WordPressBlogService
Why? Any gives ts-lint warnings and kind-of defeats TS in the first place
It's not wise to assume the date format. Use Intl to make appropriate formatting based on the current locale. Not all locales use MM/DD
For me at least, I have grown using DD/MM and it is sometimes confusing. It is better to leave the default order as per the locale.
2 new commits added
Change inline svg to svg images for icons
Add Mag View
Pull-Request has been closed by thelittlewonder
Changes the primary navigation of application to a bottom bar tabs based layout. Also Updates The design of the home page to the finalised new style (https://marvelapp.com/8j6ihg7)
Closes
- #23: Landing page for the application
- #12 Fetch Fedora magazine images from API
- #28 Navigation Fixes