PR#90: [NEED QA] Switch in-app browser views to custom tabs -

Fedora-app

#90 [NEED QA] Switch in-app browser views to custom tabs

Merged Aug 8, 2018 by a2batic. Opened Jun 21, 2018 by amitosh.

amitosh/Fedora-app custom-browser into master

amitosh commented Jun 21, 2018

Closes #15, #17, #76

Using https://github.com/agathver/cordova-plugin-custombrowser

Tests required:
* Compilation under macOS
* How does it behave if the user has disabled or has an outdated version of Chrome and has not installed Firefox?
* Testing in Android < 6

Knows issues:
* Still references my GitHub repo for the plugin, which is not optimal.

rebased onto 4ab9a7936331e49b17d9d433e0493c52f2d58295

Jun 21, 2018

amitosh commented Jun 26, 2018

Works in Android 4.4 (Xiaomi Redmi 2/MIUI 8)

rebased onto 4ae22790d4400b821dd53cb30e59dbc36a6a051e

Jul 10, 2018

rebased onto c0f16a636d85a05a23f1d94be5865771b973e7d1

Jul 26, 2018

rebased onto 1b51b983046618e62e445b56505a9508621166f1

Aug 5, 2018

a2batic commented Aug 8, 2018

Works great. Merging.

Pull-Request has been merged by a2batic

Aug 8, 2018

Metadata

Assignee

None

Tags

No Tags

Fedora-app

#90 [NEED QA] Switch in-app browser views to custom tabs Merged Aug 8, 2018 by a2batic. Opened Jun 21, 2018 by amitosh. amitosh/Fedora-app custom-browser into master

Metadata

#90 [NEED QA] Switch in-app browser views to custom tabs

Merged Aug 8, 2018 by a2batic. Opened Jun 21, 2018 by amitosh.

amitosh/Fedora-app custom-browser into master