FedoraReview

#141 "IndexError: pop from empty list" for RHBZ # 819951 (no changelog section)
Closed: Fixed Opened by salimma.

Closed: Fixed
Reopen Issue

Review # 819951 (for OSTree) provides a spec file that does not contain a changelog section. This trips up fedora-review -- both the latest stable version in F17 (0.2.2) and the Git master:

File "/home/michel/sources/fedora/projects/FedoraReview/src/FedoraReview/checks_class.py", line 181, in run_checks
test.run()
File "/home/michel/sources/fedora/projects/FedoraReview/src/FedoraReview/checks/generic.py", line 523, in run
True)
File "/home/michel/sources/fedora/projects/FedoraReview/src/FedoraReview/spec_file.py", line 241, in find_all
line = my_lines.pop()
IndexError: pop from empty list
Exception down the road...

Patch fixing the reported issue; with this fedora-review handle specs without %changelog properly
0001-141-Handle-specs-without-changelog-section.patch

We are actually using a model from http://nvie.com/posts/a-successful-git-branching-model so you probably wanted to test "devel" branch. The bug didn't happen there, but there was a different issue so thanks for bringing it to our attention.

Properly fixed in 999139017f1b1beb4ce7c5b15d7364f779eaedba
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.