FedoraReview

#192 Packages with python3 submodules broken by %licensecheck fix
Closed: Fixed Opened by toshio.

Closed: Fixed
Reopen Issue

The fix for https://fedorahosted.org/FedoraReview/ticket/73 reruns rpmbuild -bp in order to create a better environment for licensecheck to run. However, the mock chroot in which rpmbuild -bp is run does not contain all of the packages that are needed to run rpmbuild -bp. Somewhere the BuildRequires: in the spec file need to be installed into this mock chroot.

Currently, this breaks running fedora-review on any package that has a python3 submodule as macros are used in the %prep section that are defined in the python3-devel package. There are likely other packages that use macros defined in non-Buildroot packages that are similarly broken.

The fix in #73 is not just for licensecheck, there are more tests which need access to the sources as after %prep.

There is a fix in devel (see #173) which basically reruns rpmbuild -bp with all dependencies if the first attempt 'rpmbuild -bp --nodeps' fails. Could you please test the devel version to see if this problem still is present, theoretically is should be solved. The instructions to checkout devel is in the wiki.

EDIT: the reason for trying without dependencies first is sheer performance, most packages work without and it goes much faster.

The devel branch fixes the issue for me.

Toshio: are you also OK with closing this bug?

Yep, thanks for pinging!
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.