FedoraReview

#286 rpmfusion bugzilla does not work
Closed: fixed by ngompa. Opened by martinkg.

Closed: fixed
Reopen Issue

Command line: /usr/bin/fedora-review -u https://bugzilla.rpmfusion.org/show_bug.cgi?id=4670 -m fedora-rawhide-x86_64-rpmfusion_free

09-29 10:06 root DEBUG Build command: "mock" "-r" "fedora-rawhide-x86_64-rpmfusion_free" "--no-bootstrap-chroot" "--no-cleanup-after" "--no-clean" "--resultdir=/home/martin/rpmbuild/SPECS/review-shotcut/results" --rebuild /home/martin/rpmbuild/SPECS/review-shotcut/srpm/shotcut-17.09-1.fc26.src.rpm 2>&1 | tee build.log | egrep "Results and/or logs|ERROR"
09-29 10:11 root DEBUG _topdir: /builddir/build
09-29 10:11 root DEBUG Exception down the road...
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 237, in run
self._do_run(outfile)
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
self._do_report(outfile)
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 118, in _run_checks
writedown=not Settings.no_report)
File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 378, in run_checks
run_check(name)
File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 352, in run_check
check.run()
File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_build.py", line 198, in run
Mock.build(self.srpm.filename)
File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 438, in build
self.builddir_cleanup()
File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 566, in builddir_cleanup
paths = glob(os.path.join(self.get_builddir('BUILD'), '*'))
File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 339, in get_builddir
p = self._get_dir(os.path.join('root', self._topdir[1:]))
File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 178, in _get_dir
self._get_root()
File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 166, in _get_root
exec config[0] # pylint: disable=W0122
IndexError: list index out of range
09-29 10:11 root ERROR Exception down the road...(logs in /home/martin/.cache/fedora-review.log)
09-29 10:11 root DEBUG Report completed: 336.291 seconds

rpmfusion use koji-rpmfusion, not fedora-review.
Ticket can be closed.

@martinkg: What?! Could you please expand on this?

Sorry, i am totaly wrong with koji-rpmfusion.
But i am wondering, why the command finaly fails with the above messages.

Sorry i ment this command, it works now, forgot to add --scratch.
koji-rpmfusion build --scratch rawhide-free ../SRPMS/shotcut-17.10-1.fc26.src.rpm

Ticket can be closed.

Actually this is not about RPMFusion. It's a bug that fedora-review does not honor mock config syntax. RPMFusion is a good example here so I am still explain with rpmfusion config.
Please see this line : https://pagure.io/FedoraReview/blob/master/f/src/FedoraReview/mock.py#_165
Fedora-review always tries to find config_opts['root'] from the config file offered. However, this section sometimes do not exist. For example, in RPMFusion config file
https://github.com/rpmfusion-infra/mock-rpmfusion/blob/master/etc/mock/fedora-rawhide-x86_64-rpmfusion_free.cfg

They use a include('/etc/mock/fedora-rawhide-x86_64.cfg') instead of copy fedora-rawhide config again.
Mock works seamlessly with this syntax. But fedora-review not. It will result in an empty config so config[0] will report index error.
Please fix the criteria for parsing config files!
Edited by zsun

https://github.com/rpmfusion-infra/mock-rpmfusion/blob/master/etc/mock/fedora-rawhide-x86_64-rpmfusion_free.cfg
They use a include('/etc/mock/fedora-rawhide-x86_64.cfg') instead of copy fedora-rawhide config again.
Mock works seamlessly with this syntax. But fedora-review not. It will result in an empty config so config[0] will report index error.
Please fix the criteria for parsing config files!

good catch, I will check it , I'm the author of the changes in https://github.com/rpmfusion-infra/mock-rpmfusion/blob/master/etc/mock/fedora-rawhide-x86_64-rpmfusion_free.cfg ...

Thanks

I started to fix this issue here https://github.com/rpm-software-management/mock/pull/155 please take a look into commit [1], I think we might fix it in same way .

Best regards

[1]
https://github.com/rpm-software-management/mock/pull/155/commits/5b4f37a8d1bc8e299f014fa90525fd45942f22cc
Edited by sergiomb

this PR should fix it: https://pagure.io/FedoraReview/pull-request/296

Fixed in 0.7.0

Metadata Update from @ngompa:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.