#31 fedora-review fails horribly if anybody on bugzilla uses unicode in their name
Closed: Fixed Opened by psabata.

{{{
$ fedora-review -b 788990 --mock-config fedora-16-x86_64
Processing review bug : 788990
Trying bugzilla cookies for authentication
Getting .spec and .srpm Urls from bug report : 788990
Downloading .spec and .srpm files
Traceback (most recent call last):
File "/home/contyk/bin/fedora-review", line 230, in
review.run()
File "/home/contyk/bin/fedora-review", line 220, in run
self.do_report()
File "/home/contyk/bin/fedora-review", line 113, in __do_report
rc = self.bug.download_files()
File "/home/contyk/src/fedora-review/src/FedoraReview/bugz.py", line 159, in download_files
self.spec_file = self._get_file(self.spec_url)
File "/home/contyk/src/fedora-review/src/FedoraReview/__init
.py", line 213, in _get_file
stream.write(request.content)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0160' in position 2449: ordinal not in range(128)
}}}

My (correct) name on bugzilla is 'Petr Šabata'; it seems fedora-review has issues with that and prevents me from doing the review.


For completeness, could you run it with the verbose flag on ?

Thanks!

A-ha; maybe it's the unicode in changelog (0.07-2), not Bugzilla?

{{{
$ fedora-review -b 788990 --mock-config fedora-16-x86_64 -v
Processing review bug : 788990
Trying bugzilla cookies for authentication
--> Working dir : /home/contyk/src/review/788990/
Getting .spec and .srpm Urls from bug report : 788990
--> Spec url : http://v3.sk/~lkundrak/SPECS/perl-OpenOffice-UNO.spec
--> SRPM url : http://v3.sk/~lkundrak/SRPMS/perl-OpenOffice-UNO-0.07-2.el6.src.rpm
Downloading .spec and .srpm files
--> /home/contyk/src/review/788990/ : http://v3.sk/~lkundrak/SPECS/perl-OpenOffice-UNO.spec
Traceback (most recent call last):
File "/home/contyk/bin/fedora-review", line 230, in
review.run()
File "/home/contyk/bin/fedora-review", line 220, in run
self.do_report()
File "/home/contyk/bin/fedora-review", line 113, in __do_report
rc = self.bug.download_files()
File "/home/contyk/src/fedora-review/src/FedoraReview/bugz.py", line 159, in download_files
self.spec_file = self._get_file(self.spec_url)
File "/home/contyk/src/fedora-review/src/FedoraReview/__init
.py", line 213, in _get_file
stream.write(request.content)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0160' in position 2449: ordinal not in range(128)
}}}

I'm going to go with the source of the error is the same but I guess it is coming from the changelog as you said.

I'm gonna have a look at this.

Patch to fix traceback with non-ascii changelog entries
0001-Fix-UnicodeError-traceback-when-writing-unicode-cont.patch

I just applied Toshio's patch for this issue, looks good on my tests :)

Thanks Toshio!

Petr, feel free to reopen if the problem persists.

Replying to [comment:4 pingou]:

I just applied Toshio's patch for this issue, looks good on my tests :)

Thanks Toshio!

Petr, feel free to reopen if the problem persists.

It seems fixed.
Thank you, guys :)

Metadata