#349 Bug with test generic-excludearch
Opened by eclipseo. Modified

While running the review for https://bugzilla.redhat.com/show_bug.cgi?id=1690482

03-23 13:54 root         DEBUG    Running check: generic-excludearch
03-23 13:54 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks
    self.checks.run_checks(output=output, writedown=not Settings.no_report)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 382, in run_checks
    run_check(name)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 357, in run_check
    check.run()
  File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/shell_api.py", line 499, in run
    self._handle_log_messages()
  File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/shell_api.py", line 476, in _handle_log_messages
    level = eval("logging." + tag.upper())
  File "<string>", line 1, in <module>
NameError: name 'logging' is not defined

Not sure if this is related to the Py 3 conversion. The SPEC is normal, it's running meson though, don't know if this is important.


Seems like a missing import.

It seems the import has been removed at one point.

I'v probably removed it during the cleanup, it was marked as unused, but apparently wasn't.

https://pagure.io/FedoraReview/c/0a9e8db60590b661bb71d6eaf810b6fb9a2821ed?branch=master

Yes, we need to add it back, but I'm on a conference now so I won't be sending a PR soon.

Sent a merge request: https://pagure.io/FedoraReview/pull-request/350

Metadata
Related Pull Requests