FedoraReview

#364 new release + new rpm build
Closed: fixed by ngompa. Opened by dustymabe.

Closed: fixed
Reopen Issue

In f31 (fedora-review-0.7.2-2.fc31.noarch) I'm seeing an error that was fixed in latest git master:

09-08 22:00 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 108, in _run_checks
    self.checks = Checks(spec, srpm)
  File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 280, in __init__
    self.spec = SpecFile(spec_file, self.flags)
  File "/usr/lib/python3.7/site-packages/FedoraReview/spec_file.py", line 89, in __init__
    self.expand_tag(rpm.RPMTAG_NAME).decode("utf-8"),
AttributeError: 'str' object has no attribute 'decode'

can we get a new release?

Would you be willing to draft a PR? A release commit looks like this:

https://pagure.io/FedoraReview/c/65d36bb34da3c224162de93190646bcfffbd15fa?branch=master

I've got a few things in-flight right now, but I'm planning to cut a release this week so that it can land for F31 Beta.

Would you be willing to draft a PR? A release commit looks like this:
https://pagure.io/FedoraReview/c/65d36bb34da3c224162de93190646bcfffbd15fa?branch=master

Possibly - looks like neil has something planned so I'll wait. Thank @ngompa

This is now done and submitted to Bodhi:

  • Fedora 29: https://bodhi.fedoraproject.org/updates/FEDORA-2019-596b8978cd
  • Fedora 30: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5864ffc7d1
  • Fedora 31: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ec5a783a3c

Metadata Update from @ngompa:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.