FedoraReview

#48 Find a way to handle sources like git, svn etc.
Closed: Fixed Opened by leamas.

Closed: Fixed
Reopen Issue

We want this to be automatic. However, for sources like
{{{
Source: myapp-0.0.1.git1234567.tar.gz
}}}
we often need to download the source manually. This is normally described in a comment preceding the Source: line.

Things like this becomes more and more common. Many project tend to just deliver series of git commits. It would be really nice to fall back to some other mechanism when the SourceN: tag is unusable. The only realistic way I can think of is when packager provides a script which downloads the source, and a "magic comment" like
{{{

@download Source0 using "Source1 Source0"

}}}
To keep things simple, the Source1 script should be invoked with the expanded Source0: url. This will make it possible to expand macros, and force packagers to encode e. g. the git commit into the URL which is a Good Thing. The comment should still be meaningful for a human, though.

Furthermore, this would create a simple, standardized way to handle these sources. Not bad.

This is really close to the discussion that happened on the devel mailing list:
http://lists.fedoraproject.org/pipermail/devel/2012-May/166988.html

I am not sure there is much we can do at the fedora-review level. I think this needs to be solved at a broader level.

Well, we could support some kind of syntax of nothing else is available. But since this issue now is up on the mailing list, let's see what comes out of that discussion. If something like %create_tarball0 would be accepted, that's something we could support long before the standard rpm tools do (if they ever will...).

Another thing we might do is to let reviewer generate the upstream source according the instructions in the spec file (which must exist), and then provide this as input to f-r which then handles all checks. Something like

$ fedora-review -b 888888 --upstream source0:a-package.tar.gz.

This could even be required when upstream isn't a valid url.

fixed in 56855967e8b106b1
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.