$ fedora-review -r -n gamin-0.1.10-38.fc37.src.rpm -v
fails with: DEBUG: Running: mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean -qn --enable-network shell dnf repoquery -C -l filesystem Unknown argument "-C" for command "repoquery".
DEBUG: Exception down the road... Traceback (most recent call last): File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 236, in run self._do_run(outfile) File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 226, in _do_run self._do_report(outfile) File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 99, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python3.11/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks self.checks.run_checks(output=output, writedown=not Settings.no_report) File "/usr/lib/python3.11/site-packages/FedoraReview/checks.py", line 381, in run_checks run_check(name) File "/usr/lib/python3.11/site-packages/FedoraReview/checks.py", line 356, in run_check check.run() File "/usr/lib/python3.11/site-packages/FedoraReview/check_base.py", line 266, in run self.run_on_applicable() File "/usr/lib/python3.11/site-packages/FedoraReview/plugins/generic.py", line 477, in run_on_applicable filesys_dirs = set(deps.list_paths("filesystem")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/FedoraReview/deps.py", line 291, in list_paths paths = check_output(cmd, universal_newlines=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.11/subprocess.py", line 466, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.11/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['mock', '-r', 'fedora-rawhide-x86_64', '--no-cleanup-after', '--no-clean', '-qn', '--enable-network', 'shell', 'dnf repoquery -C -l filesystem']' returned non-zero exit status 2.
Thanks for the report, this is a known problem caused by the switch to dnf5 in Rawhide: https://pagure.io/FedoraReview/pull-request/481
Thanks for the reply
The -C option for dnf5 repoquery was implemented in dnf5-5.0.15. Shall we consider the issue as resolved or is there anything else missing?
-C
dnf5 repoquery
dnf5-5.0.15
@jmracek FedoraReview is still bombing out with this error unfortunately:
FedoraReview
<mock-chroot> sh-5.2# rpm -q dnf5 dnf5-5.0.15-4.fc39.x86_64 <mock-chroot> sh-5.2# dnf5 repoquery -C -l filesystem Unknown argument "-l" for command "repoquery". Add "--help" for more information about the arguments.
Here is a workaround btw https://pagure.io/FedoraReview/pull-request/485
That's because of -l is now --files. I already reported it in the DNF5 issue tracker https://github.com/rpm-software-management/dnf5/issues/696 and the fix is on its way https://github.com/rpm-software-management/dnf5/pull/707
-l
--files
The patch is included in dnf5-5.1 that is in stable for rawhide. Thank you for additional formation
fedora-review has also been patched to use dnf-3 (thanks to @frostyx ) - and the DNF 5 change is being rolled back anyway, so we can close this.
But good to know that when we switch to DNF 5 in the future it should just work!
https://pagure.io/FedoraReview/c/d8f1931fda8b64dffd8da9a275e8850a4c417dd2?branch=master
Metadata Update from @salimma: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)