#530 systemd_user issues
Opened by jjames. Modified

I am reviewing golang-codeberg-gbcox-beetpost. Fedora-review complained:

Issues:
=======
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
  for Systemd user units service files.
  Note: Systemd user unit service file(s) in golang-codeberg-gbcox-beetpost
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Scriptlets/#_user_units

There are three problems with this. First, it's an issue that systemd_user_post is invoked in %post? No, looking at the code, the issue is that fedora-review thinks that systemd_user_post is not invoked. The wording of the issue is confusing. It is positive, when it should contrast a negative reality with a positive expectation.

Second, fedora-review is wrong. The spec file has:

%post
%systemd_user_post %{project}.service
%preun
%systemd_user_preun %{project}.service
%postun
%systemd_user_postun %{project}.service

Third, fedora-review checks for %systemd_user_post and %systemd_user_preun, but fails to check for %systemd_user_postun.


Metadata