So, have published my work on this in new branch leamas. It's a big rewrite, and hard to cherry-pick from.
To my very provisional understanding, it has the potential to close about 12 of the open issues: - #2: Run tests from locally built rpms (option --prebuilt) - #4: List all available tests (from trunk) - #30:Unable to download spec file - #32 Option to use spec bundled in srpm (--rpm-spec) - #36 Partly solved, unpacked sources are in review directory on fixed location - #37 Better names for report directories - #45 Add selective test running (--exclude and --single-test) - #46 Run diff -r when md5sum differs - #47 Apply licensecheck on patched sources, after %prep - #49 In correct md5sum (possibly OK also in trunk?) - #50 rpmfusion bugzilla does not work (--url option) - #51 Configuration file: removed. Should be re-added with better semantics and documentation - #52 Running of editor: removed - #54 Default mock-config: fixed, using /etc/mock/default.cfg for default. - #55 TRaceback on 821732
Other fixes: - Rmplint test should not require silent rpmlint - Naming test should not state Naming Guidelines OK just by checking charset in name - The workdir options are removed. f-r now creates a result directory in current dir - Logging level when not using -v can be set using environment variable FR_LOGLEVEL. - Tests are normalized and can be invoked using python -m unittest ... Some more tests added. - Fixed bug caused by request library uncompressing data in some situations. - New test: rpmlint on installed package - Refactoring: code in fedora-review moved to review_helper module (testability). New modules Settings and Mock. init splitted into several new modules, basically one per class. Code to grab url:s from different sources modeled into a common class with descendants. - Provides/Requires attachments are generated - New test: package installs
This means that the bulk of ideas I have got by using f-r are implemented, I don't foresee big changes by me at this point.
Of course, testing by others is more than welcome, as is feedback (in this issue). However, I might still do push -f here, please don't trust the branch if you clone it.
Setting version = 2.0 (oops)
Reset, not push -f but delete/create. Basically bugfixes, and a somewhat cleaner history. Besides what's listed above: - Command line options reorganized into mode, general and bugzilla options - the parser can do a better job and online help + manpage becomes hopefully easier to understand. - Logging: always stores a full debug log in ~/.cache/fedora-review.log. The output has been sanitized, and by setting REVIEW_LOGLEVEL to 'warning' only important error messages are shown; normal runs are silent besides the last line about the report. - All tests now works, and a wrapper script runs them all. - Some bugs also in trunk fixed, notably failed builds is not detected.
This branch is merged. Closing