FedoraReview

#57 .desktop /desktop-file-install test fail
Closed: Fixed Opened by leamas.

Closed: Fixed
Reopen Issue

The test for properly handled .desktop files fails for this perfectly reasonable example:

{{{
desktop-file-install \
--dir %{buildroot}%{_datadir}/applications \
%{SOURCE1}
}}}
The problem is the regex used:

{{{
(desktop-file-install|desktop-file-validate)(.\\n).*desktop')
}}}

It fails for two reasons: the regex expects everything on one physical line, and it expects the argument to be *.desktop i. e., not %{SOURCE1}

Detected on my branch, but is the same on trunk.

Hm... there is more. This test will actually say 'passed' both to that the desktop file is there and that it's properly installed. But it does not test if the file is there, and couldn't because there is no way to know if this is a GUI application or not.

This test should probably be rephrased 'Desktop files are properly installed' and supplemented with another test 'GUI applications have desktop file'. The latter should pass if the desktop file is there, otherwise be pending.

Testcase in fedora BZ 818805 openerp-client

Fixed in db3a251a201
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.