#71 CheckLicenseField generates too much noise.
Closed: Fixed Opened by leamas.

It's no point reporting licenses like UNKNOWN, "GENERATED FILE" etc. These should be filtered out


fixed in f8c31952dd320172d

I am actually not sure they should be removed, they might actually be the file I would check to see if there is indeed no license or if it is just that the license was not recognized.

I see your point. Still, since they are almost always there the simple fact that they are present doesn't give much. The meaningful information is really something like "23 files cannot be classified", isn't it? And grouping them together in the detailed list...

or?!

23 files could not be classified: file1, file2, file3, file4...

Just because then you actually know which one they are (easier to find in the sources)

Yup... however, the complete list of unclassified files is potentially too big for the template, so I think it might be better to just have the summary in the template ("23 files unclassified") and the complete list in licensecheck.txt - which need to be reorganized.

Thoughts?

Reopening bug, we need to do something.

Completely fine for making the template shorter.

When reorganizing this list, goal is that it should be a usable starting point for a license break-down for cases such one is needed.

Fixed, sort of, in d4f0345bc3f091ea6e2fc089fca23a317bef6133. Room for improvements, but the output is sorted and # "unknown license" reported.

Metadata