FedoraReview

#85 api/README says "extra_output" instead of "output_extra"
Closed: Fixed Opened by mizdebsk.

Closed: Fixed
Reopen Issue

If I use "extra_output" in my JSON API calls then my check results aren't being included in the review. I had to use "output_extra" instead.

In my opinion the README should be corrected, precisely this line:
{{{
"extra_output":"text",
}}}
should be changed to:
{{{
"output_extra":"text",
}}}

Version: release-0.2.1

Since you have tested this, it shouldn't be controversial.

What's really needed is a unit test, stopping these silly mistakes form the very beginning. Since you seem to have some interest in the JSON API: have you a chance to create a (some?) unit test for it? I could help with creating the framework if need be..

Replying to [comment:1 leamas]:

What's really needed is a unit test, stopping these silly mistakes form the very beginning. Since you seem to have some interest in the JSON API: have you a chance to create a (some?) unit test for it? I could help with creating the framework if need be..
Sure, I can do that, as long as it doesn't have to be in Python because I don't know this language (which was the reason for me to use JSON API rather than coding native plugins). I can't promise it will be any soon either.

Pushed a new branch json-fixes with remedies for #84, #85 and #86. Preferably needs a unit test (#87) before merging.

Anything, even just a simple example of API usage, would be very helpful here...

Fixed in release-0.2.1
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.