FedoraReview

#89 Fails when mock configuration has nested dict
Closed: Fixed Opened by hguemar.

Closed: Fixed
Reopen Issue

fedora-review fails when mock configuration has nested dict (ie: when you setup mock plugins)
Reproducible on master and 0.2.x as it is packaged in Fedora 17 currently.

A fix would be to filter out all the configuration we don't need, since actually only config_opts['root'] is required.

I run the test suite with this patch applied and no failures was reported.

patch to fix crash in fedora-review when reading mock configuration file with nested dict
0001-bugfix-crash-when-mock-configuration-file-has-nested.patch

Just for make clear what's this is all about: could you please attach an example of such a nested config file?

Well. This patch looks like solving at least one problem, probably more. And tests runs OK.

Fixed in 4664a8aacf14. Closing. Many thanks for reporting and of course also for the patch!
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.