JShelter / webextension

#132 If macOS try to use gnu-sed instead of sed
Closed by polcak. Opened by tomeryav.
JShelter/ tomeryav/webextension main  into  main

Download 132.patch

If devs machine is MacOS try to use gnu-sed instead of sed. Since MacOS has its own sed version which leads to errors during building.
See also issue131.

Maybe it is worthy to add a note on https://jshelter.org/build/. Next to the note for step 4.
Something like On MacOS you need gnu-sed, you can install it by homebrew: brew install gnu-sed

Hello @tomeryav,

First of all thank you for your patch. However, I do not like the way that you embed your PATH which might differ in other configurations. I propose https://pagure.io/JShelter/webextension/c/78bf17f62c63278ec11f2667ff370b052f28bc24?branch=issue131

Can you check that the patch in the issue 131 branch works for you? If not, can you fix it? Thanks.

rebased onto 2f0d499d3ed5e0e2f041d3954d468d38b5f32d0b

Hi @polcak,
I like your proposal and see your point, thanks!

It nearly worked, you just missed to replace the last line ( line 44) with $SED instead of sed.
I adjusted my PR to look like your proposal, not the intention to steal any credits just thought that was what you mean by

If not, can you fix it?

:)

Edited by tomeryav

Yes that is what I meant. Thank you. However, I liked my explanation of the commit better. But I referenced both issues so lot of credit goes to you.

Pull-Request has been closed by polcak
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.