#1103 SSSD needs to build with -fno-strict-aliasing
Closed: Fixed Opened by sgallagh.

https://bugzilla.redhat.com/show_bug.cgi?id=757810

Description of problem:
rpmdiff reports:
The build log on i386 has serious warnings that may cause run-time
errors/crashes; suggest use of -fno-strict-aliasing:
  2093  src/providers/ipa/ipa_init.c: In function 'sssm_ipa_access_init':
  2094  src/providers/ipa/ipa_init.c:354: warning: dereferencing type-punned
pointer will break strict-aliasing rules
  2149  src/providers/ldap/sdap_async_accounts.c: In function
'sdap_fill_memberships':
  2150  src/providers/ldap/sdap_async_accounts.c:648: warning: dereferencing
type-punned pointer will break strict-aliasing rules
  2512  src/sss_client/pam_sss.c: In function 'do_pam_conversation':
  2513  src/sss_client/pam_sss.c:331: warning: dereferencing type-punned
pointer will break strict-aliasing rules
  2514  src/sss_client/pam_sss.c: In function 'user_info_offline_auth':
  2515  src/sss_client/pam_sss.c:600: warning: dereferencing type-punned
pointer will break strict-aliasing rules
  2516  src/sss_client/pam_sss.c: In function 'user_info_offline_auth_delayed':
  2517  src/sss_client/pam_sss.c:727: warning: dereferencing type-punned
pointer will break strict-aliasing rules
Version-Release number of selected component (if applicable):
sssd-1.5.1-41.el5
How reproducible:
Every time
Steps to Reproduce:
1. Build SSSD in Brew
2. Examine build logs
3.
Actual results:
Warnings about dereferencing type-punned pointers appear in the logs.
Expected results:
No such warnings.
Additional info:
This is not an issue on Fedora or RHEL 6, as -fno-strict-aliasing is a default
build flag on those platforms.
QE can verify this bug trivially by viewing the build logs of the SSSD version
being tested.

Fields changed

coverity: =>
description: https://bugzilla.redhat.com/show_bug.cgi?id=757810

{{{
Description of problem:
rpmdiff reports:
The build log on i386 has serious warnings that may cause run-time
errors/crashes; suggest use of -fno-strict-aliasing:

2093 src/providers/ipa/ipa_init.c: In function 'sssm_ipa_access_init':
2094 src/providers/ipa/ipa_init.c:354: warning: dereferencing type-punned
pointer will break strict-aliasing rules
2149 src/providers/ldap/sdap_async_accounts.c: In function
'sdap_fill_memberships':
2150 src/providers/ldap/sdap_async_accounts.c:648: warning: dereferencing
type-punned pointer will break strict-aliasing rules
2512 src/sss_client/pam_sss.c: In function 'do_pam_conversation':
2513 src/sss_client/pam_sss.c:331: warning: dereferencing type-punned
pointer will break strict-aliasing rules
2514 src/sss_client/pam_sss.c: In function 'user_info_offline_auth':
2515 src/sss_client/pam_sss.c:600: warning: dereferencing type-punned
pointer will break strict-aliasing rules
2516 src/sss_client/pam_sss.c: In function 'user_info_offline_auth_delayed':
2517 src/sss_client/pam_sss.c:727: warning: dereferencing type-punned
pointer will break strict-aliasing rules

Version-Release number of selected component (if applicable):
sssd-1.5.1-41.el5

How reproducible:
Every time

Steps to Reproduce:
1. Build SSSD in Brew
2. Examine build logs
3.

Actual results:
Warnings about dereferencing type-punned pointers appear in the logs.

Expected results:
No such warnings.

Additional info:
This is not an issue on Fedora or RHEL 6, as -fno-strict-aliasing is a default
build flag on those platforms.

QE can verify this bug trivially by viewing the build logs of the SSSD version
being tested.
}}}
=> https://bugzilla.redhat.com/show_bug.cgi?id=757810

{{{
Description of problem:
rpmdiff reports:
The build log on i386 has serious warnings that may cause run-time
errors/crashes; suggest use of -fno-strict-aliasing:

2093 src/providers/ipa/ipa_init.c: In function 'sssm_ipa_access_init':
2094 src/providers/ipa/ipa_init.c:354: warning: dereferencing type-punned
pointer will break strict-aliasing rules
2149 src/providers/ldap/sdap_async_accounts.c: In function
'sdap_fill_memberships':
2150 src/providers/ldap/sdap_async_accounts.c:648: warning: dereferencing
type-punned pointer will break strict-aliasing rules
2512 src/sss_client/pam_sss.c: In function 'do_pam_conversation':
2513 src/sss_client/pam_sss.c:331: warning: dereferencing type-punned
pointer will break strict-aliasing rules
2514 src/sss_client/pam_sss.c: In function 'user_info_offline_auth':
2515 src/sss_client/pam_sss.c:600: warning: dereferencing type-punned
pointer will break strict-aliasing rules
2516 src/sss_client/pam_sss.c: In function 'user_info_offline_auth_delayed':
2517 src/sss_client/pam_sss.c:727: warning: dereferencing type-punned
pointer will break strict-aliasing rules

Version-Release number of selected component (if applicable):
sssd-1.5.1-41.el5

How reproducible:
Every time

Steps to Reproduce:
1. Build SSSD in Brew
2. Examine build logs
3.

Actual results:
Warnings about dereferencing type-punned pointers appear in the logs.

Expected results:
No such warnings.

Additional info:
This is not an issue on Fedora or RHEL 6, as -fno-strict-aliasing is a default
build flag on those platforms.

QE can verify this bug trivially by viewing the build logs of the SSSD version
being tested.
}}}

owner: somebody => sgallagh
patch: => 1
rhbz: =>
status: new => assigned
tests: => 0
testsupdated: => 0
upgrade: => 0

Fixed by
- be1ef1c62ad13612be5e1f879476c24452a5d6d0 (master)
- 75c231ac398dca30ae9b3f07697a5d2f4ac40090 (sssd-1-6)
- c8631fb8dd3e38376a09581ec040ffde84a32ea8 (sssd-1-5)

resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => [https://bugzilla.redhat.com/show_bug.cgi?id=757810 757810]

Metadata Update from @sgallagh:
- Issue assigned to sgallagh
- Issue set to the milestone: SSSD 1.5.16

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2145

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata