#1864 Bad comparisons in checks found by new Coverity instance
Closed: Fixed Opened by jhrozek.

The new Coverity instance found several cases where we check for a different variable name after allocation or a different operation, such as here:

385                rdomain = talloc_strdup(tmp_ctx, default_domain);
386                if (default_domain == NULL) {
387                    DEBUG(SSSDBG_OP_FAILURE, ("talloc_strdup failed.\n"));
388                    ret = ENOMEM;
389                    goto done;
390                }

This ticket tracks all there problems.


Fields changed

coverity: 10021 => 10021, 10020,10014

Fields changed

coverity: 10021, 10020,10014 => 10021, 10020,10014,10013

Fields changed

owner: somebody => jhrozek
patch: 0 => 1
status: new => assigned

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.10.0
rhbz: => 0

Fields changed

milestone: SSSD 1.10.0 => SSSD 1.10 beta

  • master: 274fe6a4f8bcb23e31929430110c0b52e9ce233a

resolution: => fixed
status: assigned => closed

Additional fix: 4d09e8abf9f4306d3d6add88ee9100373c421c74

Metadata Update from @jhrozek:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.10 beta

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/2906

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata