#526 Unsafe talloc_move() in group_show_recurse_next()
Closed: Fixed Opened by sgallagh.

Line 760:

group_members = talloc_move(recurse_req, &group_members);

Reassigning directly to group_members is a bad idea, as talloc_move() may return NULL on error, and the memory for group_members will remain attached to its former parent. This may result in accessing freed memory.


Valid bug, but applies to 1.2 only

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.2.1

Fields changed

status: new => assigned

Fixed by a28ca31bb77ce38bb8821681b00113fd6525fa17

fixedin: => 1.2.1
resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.2.1

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1568

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata