#3645 Avoid double semicolon warnings on older compilers
Merged by lslebodn. Opened by asn.
SSSD/ asn/sssd master-fallthrough  into  master

Download 3645.patch

Compilers that don't support fallthrough will end up with an empty
SSS_ATTRIBUTE_FALLTHROUGH define and just see a semicolon. The probably
will warn that there are double semicolons in the code.

Signed-off-by: Andreas Schneider asn@redhat.com

maybe we could expand that to comment which is recognized by linters, static analyzers. e.g. "/ fallthrough /"

I didn't test that because I already have gcc8 on my machine :-)

that would just add a comment to the #define

#define SSS_ATTRIBUTE_FALLTHROUGH ((void)0) /* fall through */

/facepalm

ACK

Commit 1ef36a87 fixes this pull-request

Pull-Request has been merged by lslebodn

Metadata