SSSD / sssd

#3691 SYSTEMD: Allow to use "/run" in ListenStream
Merged by jhrozek. Opened by lslebodn.
SSSD/ lslebodn/sssd sockets_rustatedir  into  master

Download 3691.patch

/var/run is only symbolic link to /run on some distributions
and /run is mounted on tmpfs

sh-4.4$ ls -l /var/run
lrwxrwxrwx. 1 root root 6 Dec 12  2015 /var/run -> ../run

Previously, we used $(localstatedir)/run in ListenStream
which does not allow to use "/run" because we still need to
store some files in under $(localstatedir) (/var).

Autoconf 2.70 will add new configure time option --runstatedir
for configuring runstatedir. ATM, we use just fallback implementation
where $(runstatedir) is set to $(localstatedir)/run

rebased onto a9c03fbd1dedf27a27fc05e7601b0d3a758f1a9a

ACK, sorry this stalled for so long.

BTW we can add also following changes to spec file (of course conditionally)

diff --git a/sssd.spec b/sssd.spec
index 25314596b..dfe31c7ff 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -743,6 +743,7 @@ autoreconf -ivf
     --enable-nsslibdir=/%{_lib} \
     --enable-pammoddir=/%{_lib}/security \
     --enable-nfsidmaplibdir=%{_libdir}/libnfsidmap \
+    --with-pid-path=/run \
     --disable-static \
     --disable-rpath \
 %if %{with sssd_user}
@@ -758,7 +759,8 @@ autoreconf -ivf
     %{?with_kcm_option} \
     %{?experimental}
-make %{?_smp_mflags} all
+make %{?_smp_mflags} all \
+     runstatedir=/run

Just let me know.

I don't know. If you think it would be beneficial, then yes, but I think a separate PR would be better (I'll push this one later today to avoid blocking our internal CI with post-commit runs)

I don't know. If you think it would be beneficial, then yes, but I think a separate PR would be better (I'll push this one later today to avoid blocking our internal CI with post-commit runs)

make sense

Commit f64e9587 fixes this pull-request

Pull-Request has been merged by jhrozek

Commit 7ddbcd8f fixes this pull-request

Pull-Request has been merged by jhrozek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.