#8 logind: add debug messages to session creation logic
Merged by daandemeyer. Opened by naccyde.
centos-sig-hyperscale/ naccyde/systemd systemd-logind-verbose  into  hs+fb-v255.4

Download 8.patch

In order to debug an issue where logind keeps a lot of session in
"opening" state, we need to add debug messages to the session creation
logic.

Signed-off-by: Quentin Deslandes qde@naccy.de

Why isn't this an upstream change?

This change is specific to an issue we've been dealing with in production. We don't know yet what is going on, so the idea it to makesystemd-logind more verbose in order to gather information. That's the reason this change is targeting hs+fb specifically.

I should have mentioned that in the PR!

Honestly, I'm not sure why more verbosity tagged with debug isn't valuable generally anyway, but sure...

Since this is an fb branch, poking @dcavalca and @daandemeyer.

rebased onto 9c746dc5a467e830d5b224afb8d0e2224aabf5af

rebased onto ca38171eceb348ba845303cac13e8a34508e48d4

Rebased on hs+fb-v255.4

rebased onto 32b61949c0c68aeeb9cb3fc9030b6028c6a12a0e

rebased onto 5706f7b056abb0aca66af4206210cbb8355b8b65

rebased onto 9f12a001f0e09991acddce36e469510476aadc25

log_debug_errno?

This will also crash, you should only use log_debug_errno() if there's an error. Please just use log_debug() here.

Ditto

Ditto

Ditto

Ditto

rebased onto 90bd416fb2582b8b3957ad9836ef2a3c6102f5cf

rebased onto fad9451f4e8d056dee0780cd38a7fc98a221d4e4

Pull-Request has been merged by daandemeyer

Metadata