#216 Investigate error handling on multiple cert requests
Closed: migrated by dmoluguw. Opened by edewata.

In the original ProfileSubmitServlet (or in the new ProfileProcessor) when processing multiple requests an error for one request may affect the processing for subsequent requests. It's not clear yet whether this is intentional or a bug.

See the following code:

String errorCode = null;
for (int k = 0; k < reqs.length; k++) {
    try {
        ...
        profile.submit(authToken, reqs[k]);
        ...
    } catch (Exception e) {
        errorCode = ...
    }
    if (errorCode == null) {
        profile.getRequestQueue().markAsServiced(reqs[k]);
    } else {
        profile.getRequestQueue().updateRequest(reqs[k]);
    }
}

The errorCode is null initially, then it will be set to a certain value if a request fails. However, the errorCode is not reset to null before processing the next request, so even if the next request works fine it will have the errorCode from the previous request. The errorCode is used to determine whether to call markAsServiced() or updateRequest() for each request.


Metadata Update from @edewata:
- Issue set to the milestone: UNTRIAGED

Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.

This issue has been cloned to GitHub and is available here:
https://github.com/dogtagpki/pki/issues/787

If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.

Thank you for understanding, and we apologize for any inconvenience.

Metadata Update from @dmoluguw:
- Issue close_status updated to: migrated
- Issue status updated to: Closed (was: Open)

Metadata