dogtagpki

#2838 Inconsistent CERT_REQUEST_PROCESSED outcomes.
Closed: fixed Opened by edewata.

Closed: fixed
Reopen Issue

The following CERT_REQUEST_PROCESSED events seem to have incorrect outcomes.

These successes probably should have been failures:

  • https://github.com/dogtagpki/pki/blob/0f3e03ee3ee0afb3044f61ce1d091493ed76eded/base/server/cms/src/com/netscape/cms/servlet/request/ProcessCertReq.java#L1090
  • https://github.com/dogtagpki/pki/blob/0f3e03ee3ee0afb3044f61ce1d091493ed76eded/base/server/cms/src/com/netscape/cms/servlet/request/ProcessCertReq.java#L1148

These failures probably should have been successes:

  • https://github.com/dogtagpki/pki/blob/0f3e03ee3ee0afb3044f61ce1d091493ed76eded/base/server/cms/src/com/netscape/cms/servlet/request/ProcessCertReq.java#L467
  • https://github.com/dogtagpki/pki/blob/0f3e03ee3ee0afb3044f61ce1d091493ed76eded/base/server/cms/src/com/netscape/cms/servlet/request/ProcessCertReq.java#L1255
  • https://github.com/dogtagpki/pki/blob/0f3e03ee3ee0afb3044f61ce1d091493ed76eded/base/server/cms/src/com/netscape/cms/servlet/request/ProcessCertReq.java#L1298
  • https://github.com/dogtagpki/pki/blob/0f3e03ee3ee0afb3044f61ce1d091493ed76eded/base/server/cms/src/com/netscape/cms/servlet/request/ProcessCertReq.java#L1342
  • https://github.com/dogtagpki/pki/blob/0f3e03ee3ee0afb3044f61ce1d091493ed76eded/base/server/cms/src/com/netscape/cms/servlet/request/ProcessCertReq.java#L1386

Per discussion with cfu and alee, the CERT_REQUEST_PROCESSED's outcome can be interpreted in two ways:

  1. Success means that the request has been processed, but the certificate may or may not be issued, depending on approval or rejection. Failure means that there is a problem so the request cannot be processed.

  2. Success means the request is approved so the certificate is issued. Failure means that the certificate is not issued due to rejection or other problems.

The definition of the outcome needs to be clarified first, then the code needs to be fixed accordingly.

See also ticket #2663 and #2690.
Edited by edewata

Metadata Update from @edewata:
- Custom field component adjusted to None
- Custom field feature adjusted to None
- Custom field origin adjusted to None
- Custom field proposedmilestone adjusted to None
- Custom field proposedpriority adjusted to None
- Custom field reviewer adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

Metadata Update from @mharmsen:
- Issue set to the milestone: 0.0 NEEDS_TRIAGE

Metadata Update from @mharmsen:
- Custom field proposedmilestone adjusted to 10.5 (was: None)
- Custom field proposedpriority adjusted to critical (was: None)

Metadata Update from @mharmsen:
- Issue assigned to edewata

Per meeting of 20171113 - 10.5 - critical

Metadata Update from @mharmsen:
- Issue priority set to: critical
- Issue set to the milestone: 10.5 (was: 0.0 NEEDS_TRIAGE)

Metadata Update from @mharmsen:
- Custom field proposedmilestone adjusted to None (was: 10.5)

Metadata Update from @mharmsen:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1539198

Fixed in master:

  • https://github.com/dogtagpki/pki/commit/8319105ba04976494e05030ee5340b5879ad6a48

Fixed in 10.5 branch:

  • https://github.com/dogtagpki/pki/commit/5af21f519b7bbc6106ede549ed81974520e21e5d

Metadata Update from @edewata:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

Metadata Update from @mharmsen:
- Issue set to the milestone: 10.5.5 (was: 10.5)

Metadata Update from @mharmsen:
- Custom field fixedinversion adjusted to pki-core-10.5.5-1.fc27

Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.

This issue has been cloned to GitHub and is available here:
https://github.com/dogtagpki/pki/issues/2958

If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.

Thank you for understanding, and we apologize for any inconvenience.
Metadata
None
None
None
Low
pki-core-10.5.5-1.fc27
None
None
None
None
None
None
critical
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.