elections

#100 Make the FPCA+1 requirement used by FESCo optional
Merged by bcotton. Opened by bcotton.
fix_fpca_plusone  into  develop

Download 100.patch

My local test environment is being uncooperative, so I'd like to get some eyes on this before I rebase it into staging to make sure I didn't miss anything obvious.

@pingou if you have a moment, can you tell me how incredibly wrong this is? :wink:

Shouldn't this be a boolean field? :)

Shouldn't this be a boolean field? :)

Perhaps. "Candidates are FAS users" is also an integer, so that's what I went with. I'm not sure if there are historical reasons for that or if I'm just carrying a mistake forward. :-)

Shouldn't this be a boolean field? :)

Perhaps. "Candidates are FAS users" is also an integer, so that's what I went with. I'm not sure if there are historical reasons for that or if I'm just carrying a mistake forward. :-)

I'm not sure if it's one or the other, but I think a boolean field here should be sufficient

1 new commit added

  • Make requires_plusone a boolean

1 new commit added

  • Add tests for the FPCA +1 check

rebased onto 896f420d527d2a6ecab763e8c63b0ff25837ed96

Added tests and squashed for merge

(I did not address the Black changes yet because that seemed better to do in a separate pass)

Will merge and then rebase stg with this

Pull-Request has been merged by bcotton
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.