#61 Port election to open-id connect
Merged by pingou. Opened by pingou.
oidc  into  develop

Download 61.patch
no initial comment

rebased onto a5103002da96ceea6436c106f3c9af3d57c37124

Why the change in the port?

I recommend splitting this into separate tests

I recommend splitting this into separate tests

I recommend splitting this into separate tests

I recommend splitting this into separate tests

Same as above, maybe consider creating a test class for every function.

Same as above

Same as above

Same as above

I don't want to comment on every method in this test, but you should consider creating test class for every function and test every case in separate method. It will be much more readable and you will quickly find the failing test.

It's the default port used by flask, fixing the doc here :)

I don't want to comment on every method in this test, but you should consider creating test class for every function and test every case in separate method. It will be much more readable and you will quickly find the failing test.

Doable but this will increase the diff and isn't quite in the scope of this PR :)

5 new commits added

  • Document how to register the app for dev
  • Port unit-tests to OpenID-Connect
  • fixup oidc
  • Add the OIDC_OPENID_REALM on port 5005
  • Port elections to openid-connect

rebased onto e5cf2fa9a13172ec591a108b81653e5942410322

Rebased on the top of develop :)

I don't want to comment on every method in this test, but you should consider creating test class for every function and test every case in separate method. It will be much more readable and you will quickly find the failing test.

Doable but this will increase the diff and isn't quite in the scope of this PR :)

Let's create a issue to track this work.

Otherwise LGTM

I'm trying to fix the conflict, but +1 on a ticket to refactor the test suite :)

rebased onto 75aa26ed6c4788fa5d15815714133fca2ce4c136

There are still some failing tests it seems (https://jenkins-fedora-apps.apps.ci.centos.org/blue/organizations/jenkins/elections/detail/oidc/1/pipeline#step-43-log-28)

1 new commit added

  • Specify in tox.ini the configuration file to use for the tests

The tests passed, but the run failed because of diff-cover: https://jenkins-fedora-apps.apps.ci.centos.org/blue/organizations/jenkins/elections/detail/oidc/7/pipeline

Thanks! :)

Pull-Request has been merged by pingou

Metadata