PR#78: Update production with bugfixed version 2.9 -

elections

#78 Update production with bugfixed version 2.9

Closed Mar 17, 2020 by bcotton. Opened Nov 15, 2019 by bcotton.

develop into production

bcotton commented Nov 15, 2019

Incorporate a few bugfixes before the election. I didn't get a chance to do the over-aggressive-group check, so I'll defer that until after the F31 elections.

@pingou can you please look this over and double-check me? If it looks good, you can merge and deploy to prod before by EOB on Wednesday.

Metadata Update from @bcotton:
- Request assigned

Nov 15, 2019

pingou commented Nov 18, 2019

Everytime we open in a new window we should add rel="noopener noreferrer" as well to ensure no data is passed by the browser to the receiving end.

pingou commented Nov 18, 2019

I'd keep the ansible pieces out for now.

There is a merge commit you can likely get ride of using rebase.

The changes regarding target="_blank" look fine with the comment made above about rel="noopener noreferrer".

I have the habit to bump the release only when I make a new release, so it's a specific commit bumping the release, updating the spec file with changelog and all. I find that it makes it easier to match releases <-> commits which is sometime quite useful :)

bcotton commented Nov 18, 2019

Closing in favor of a cleaner #79

rebased onto e2a9d0a86fe918fefd55b4cf0f98fce0442e882f

Nov 24, 2019

pingou commented Mar 17, 2020

@bcotton looks like you rebased the PR instead of closing it :)

Pull-Request has been closed by bcotton

Mar 17, 2020

bcotton commented Mar 17, 2020

/me whistles innocently