I would like to update fish to version 4.0.0 in EPEL 10.0 and 10.1. This version is rewritten from C++ to Rust, and while there aren't that many user-facing backward incompatible changes, there are some. Upstream has extensive documentation on this front: https://github.com/fish-shell/fish-shell/releases/tag/4.0.0
fish
This is technically a new incompatible version series, but as RHEL 10.0 is not GA yet, I would prefer to be able to ship in EPEL 10 series the version series of fish that upstream will be actively maintaining and developing.
+1
+1 (as proposer)
The motivation makes sense to me, but I'd like to hear more about those incompatible changes. I see what upstream wrote in the release notes, but which ones of those do you think have the highest potential to have an impact on EPEL users? Those should be called out specifically in the email to epel-devel (step 1) and epel-announce (step 6).
Considering that this is effectively a new program, and the list of changes is quite long, we may want to take our time with this a bit. I also don't see any security issues mentioned, so I don't think there is a need to rush. Rather than the minimum one week discussion and one week in testing, I'd like to see at least a few weeks in testing to give users more time to identify potential problems. It may also be worthwhile to build it in copr first and give users a chance to test from there before even making the changes in dist-git.
The most "serious" incompatibility is the default change to "Ctrl+C":
ctrl-c now calls a new bind function called clear-commandline. The old behavior, which leaves a “^C” marker, is available as cancel-commandline
ctrl-c
clear-commandline
cancel-commandline
The rest are mostly invisible changes and don't really affect the scripting interface of fish.
I'm +1, but I like Carl's idea of having a COPR to test first and giving it some extra time to settle. We definitely should try and get this out before GA though -- so roughly before Summit?
+1 I think it's good to do this before GA...
Here's a COPR if you want to try it out first: https://copr.fedorainfracloud.org/coprs/ngompa/fish4/
$ sudo dnf copr enable ngompa/fish4 $ sudo dnf distro-sync fish
There have been no serious objections over the three weeks that this has been proposed on list or in the ticket. I would like to get this done next week, can people please vote on it?
+1 from me
I do want to caution against the logic of "RHEL 10.0 is not GA yet", because EPEL 10 and CentOS 10 are already released. But the rest of the motivation makes sense to me, and the incompatibilities seem ok, so I'm +1 to proceed with the incompat upgrade process.
In this weeks meeting, we ran out of time while discussing this issue. We said that we would do the vote in this ticket. The only vote we are missing is @dcavalca .
That makes the vote 7(+1) 0(-1) 1 not voting.
This request has passed.
Please proceed with the rest of the Incompatible Upgrade steps.
Metadata Update from @tdawson: - Issue close_status updated to: Approved - Issue status updated to: Closed (was: Open)
This issue has been migrated to Fedora Forge: https://forge.fedoraproject.org/epel/steering/issues/319
Please continue any further discussion there.