... tries to perform the following operations...
Looks good to me. Just two ideas: What about using level three heading for the rpmdeplint tests? Currently, with the definition list it's a bit confusing when the test description has multiple paragraphs. And second: What about including links to project documentation for each tool and/or place where to file issues? Could be useful.
rpmdeplint
One more thought: For the asciidoc format there's a recommendation to write one sentence per line. It helps with reviews and further text adjustments.
3 new commits added
[generic_tests] perform *the* following operations
[generic_tests] Turn rpmdeplint checks into 3rd level headers
[generic_tests] Have one sentence per line
@psss thanks for the review. I updated the pull request.
@msrb yep, I have similar commments, I would like to see this stricture of the page
Table of Contents Available generic tests rpmdeplint check-sat check-repoclosure check-conflicts check-upgrade rpminspect installability Adding new generic test
Could we describe here how is the build we compare against chosen?
@mvadkert since this page is meant to be a short description of what's available for end users, I don't think the "Adding new generic test" section should be on this page.
1 new commit added
[generic_tests] rpminspect: add note about the previous build
I added note about the previous build used by rpminspect.
or "kernel"), but can without a comma
or "kernel"), but can
packages in the context probably the needs to be added
packages in the context
the
that is, when one no need comma here
that is, when one
probably favor not favour
favor
favour
please, remove one space assuming the package
assuming the package
one of the given packages not package
one of the given packages
package
Thanks for the adjustments, Michal. Looks good to me now.
I can live with the current content also :)
[generic_tests] Address sturivny's PR comments
@sturivny Thanks for the comments also -- I've updated the PR and I am going to merge it now :)
Pull-Request has been merged by msrb