fedora-ci / messages

#24 Support for multiple examples for one message
Closed by psss. Opened by pholica.

Closed
Reopen Issue

In PR#23 there's added support for image testing which is sent when testing different test type/category of the productmd-compose.test. Since the image is optional and makes sense only when running the image test, it would be good to have example for both compose test (currently in examples) and for image in compose (containing additional "image" field and having different type and/or category).

What about supporting several examples by adding an optional number suffix just before the json extension`? So instead of:

productmd-compose.test.complete.json

we would have something like this:

productmd-compose.test.complete.1.json
productmd-compose.test.complete.2.json

Or including a note at the end?

productmd-compose.test.complete(basic).json
productmd-compose.test.complete(image).json

Which seems better? Any other idea?

I like the latter exmaple more, eventhough it contains parantheses. Gives more context :)

The fix for this is proposed in #30. Instead of using parenthesis (which are special character in shell and cause troubles in Makefile as well) I used the plus sign. Is it ok?

Metadata Update from @psss:
- Issue assigned to psss

That's great, I like the approach containing description. Plus sounds good too.

@pholica, @mvadkert, thanks for the feedback. Going to merge.

Metadata Update from @psss:
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.