#23 Default execute implementation is shell [fix #20]
Merged by psss. Opened by psss.
fedora-ci/ psss/metadata shell  into  master

Download 23.patch

rebased onto da4f947ecb7a18c538192434e77dacaa5b2d5b1e

hm hm, so I am not sure this works:

$ printf "echo nini\nfalse\necho $?" | ssh host
nini
0

So I guess we will need to solve this a bit differently .... moving it on the host as a script maybe ...

Definitely, or execute one command after another. But that up to the implementation to behave consistently and reasonably.

Definitely, or execute one command after another.

Then $? won't work? :)

But that up to the implementation to behave consistently and reasonably.

I guess it would be nice if a multiline script would make usage of variables possible, will sort that out ...

The spec says:

In that case executor will store given script into a file and execute.

So I think that part is clear. And variables should be supported. Perhaps we could extend the list section with something like this:

You can also include several commands as a list. This will
execute commands one-by-one and check exit code of each.

Does it make it a bit more clear?

Definitely, or execute one command after another.

Then $? won't work? :)

Right, that was a stupid idea. As mentioned by @psss, "in that case executor will store given script into a file and execute", and that's it.

But that up to the implementation to behave consistently and reasonably.

I guess it would be nice if a multiline script would make usage of variables possible, will sort that out ...

rebased onto 747be27e4fb06f3ec5637637eb55046b7e59e75f

Clarified that list of shell commands will be executed one-by-one. @mvadkert, ok to merge?

LGTM :100:

Great, thanks for the feedback. Merging.

Pull-Request has been merged by psss

Metadata