#3 Fixed multi-build, so that it conforms to the refactor
Merged by pingou. Opened by asaleh.
fedora-ci/ asaleh/monitor-gating multi_build_refactor  into  master

Download 3.patch

Fixed multi-build, so that it conforms to the refactor
Added more log messages
Made script to fail on failing clones, pulls and pushes.

I don't think we're catching these exception higher in the stack so this would break the scripts.

Also: if we do want to keep them here: we could/should just re-raise the previous exception (exception MonitoringException as err: .... raise err)

One comment from just reviewing the code, otherwise looks good (I'll just need to test it before giving a final +1)

rebased onto 22ce74a26a651bd2fd632c92c4bb95c735e9fd19

Missing "utils."

Same here

1 new commit added

  • Fixed missing utils. for some print_user calls, removed unused imports

These messages don't appear to me, they are overriden by the print_user within lookup_results_datagrepper so I'd be inclined to just remove them.
What do you think?

They are there to let me know how far has the script gone if it got stuck.

1 new commit added

  • Removed extra print messages in monitor_gating.py

rebased onto 51a7631a33f3da499c45719d5d8efb24d87713e2

Ok, things are still not working but it's not related to these changes, so let's get them in! :)

Thanks!

Pull-Request has been merged by pingou

Metadata