#9 WIP: Move code into its own `monitor_gating` package, add a setup script and misc fixes
Merged by pingou. Opened by nphilipp.
fedora-ci/ nphilipp/monitor-gating master--python-package  into  master

Download 9.patch

4 new commits added

  • Add and use setup.py, requirements.txt
  • Dockerfile: install default configuration file
  • Make container entrypoint script more flexible
  • Move code into its own `monitor_gating` package

WIP, because the setup script doesn't set a license yet.

4 new commits added

  • Add and use setup.py, requirements.txt
  • Dockerfile: install default configuration file
  • Make container entrypoint script more flexible
  • Move code into its own `monitor_gating` package

Let's put this in the same RUN as below to save one layer :)

Why using these variables? I think I've seen this pattern elsewhere, but I don't quite understand it since the variables aren't used anywhere but in the setup() below

Yeah, I tend to split RUN statements so that safe, long-running actions come first and what I'm changing after it, but then don't remember to put them back together again. :wink:

This pattern is "copy a setup.py you had lying around, then change things". :grinning:
I'll shorten it.

4 new commits added

  • Add and use setup.py, requirements.txt
  • Dockerfile: install default configuration file
  • Make container entrypoint script more flexible
  • Move code into its own `monitor_gating` package

rebased onto 17662ad01f19bba9deb3a75398d95ffcde682b34

:thumbsup: for me, thanks!

Pull-Request has been merged by pingou

Metadata