fedora-commops / fedora-happiness-packets

#193 Auto reflecting of changes in front-end files (templates & static files) in browser
Closed by revanth. Opened by revanth.
fedora-commops/ revanth/fedora-happiness-packets master  into  master

Download 193.patch

Volumes in docker-compose.yaml file is reupdated with z portion.

PS: The 'z' option tells Docker that the volume content will be shared between containers.

@jflory7 sorry for reopening the same pr #183 . My system ran into trouble and I opened the PR again.

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, improvement, type - internal organization, type - summer coding

@revanth Thanks for the PR. I tested this and it no longer works for me. I made changes from my local repo and they weren't changed in the Docker image; I made changes inside the Docker image and they weren't changed in my local repo. Also, I think it's worthwhile to make as much of the root folder a volume as well, in case any back-end changes are made. Currently, it would only affect changes to assets and templates.

Could you look again to fix this? I'm not sure exactly what the issue is yet.

Metadata Update from @jflory7:
- Pull-request tagged with: needs changes

Metadata Update from @jflory7:
- Request assigned

@jflory7 Thanks for your valuable feedback. Sure, I will recheck it.
As per what I understood from your reply is that changes are visible only in assets and templates, right?.

Also, I think it's worthwhile to make as much of the root folder a volume as well, in case any back-end changes are made. Currently, it would only affect changes to assets and templates.

Should I make the root folder a volume???
Edited by revanth

As per what I understood from your reply is that changes are visible only in assets and templates, right?.

Unfortunately nothing changed for me when I tested from the latest commit. It was a regression from when I first tested PR #183.

Should I make the root folder a volume???

Yes, I think it's okay for now.

Pull-Request has been closed by revanth
Metadata
jflory7

PASSED improvement needs changes type - internal organization type - summer coding

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.