#225 Disable sending emails to Sender themselves
Merged by jflory7. Opened by alishapapun.
fedora-commops/ alishapapun/fedora-happiness-packets stop-email-to-youself  into  master

Download 225.patch

This PR is regarding #217

Metadata Update from @jflory7:
- Pull-request tagged with: improvement, needs testing, type - backend, type - summer coding
- Request assigned

Please change the function name to adhere to Python PEP-8 standards. Function names should be lowercase, with words separated by underscores as necessary to improve readability. More specifics explained on python.org.

Please change the function name to adhere to Python PEP-8 standards. Function names should be lowercase, with words separated by underscores as necessary to improve readability. More specifics explained on python.org.

Minor, minor typo: doesnot to does not

I think this error is not clear since a recipient can be anyone, not only the sender. I suggest this edit instead: You cannot send a Fedora Happiness Packet to yourself!

The Python PEP-8 standard suggests maximum line length of 79 characters (python.org). While minor, it does make PRs in the Pagure web UI easier to read / write since in-line comments extend off-screen. You can delete the commented line and shorten the following line in this way to adhere to PEP-8:

        if normalized_recipient_email in (
                sender_email, sender_fedora_email, normalized_sender_email):

Thanks @alishapapun, great work! :tada: I tested this locally and it worked as expected when I tried to send a packet to myself. I left a few comments with minor change requests. When you get a chance to get to this feedback, we can merge this. :smiley: Thanks for working on this.

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
- Pull-request tagged with: needs changes

rebased onto 6fe957fb1642d80c3fe83ebe34e7eaaf93e47041

Hey, @jflory7 I made the required changes and squashed the commits to 1. Do let me know if any further changes are required. Cheers :smile:

Metadata Update from @jflory7:
- Pull-request untagged with: needs changes

Thanks @alishapapun, the changes look good to me. :smile: Thanks for addressing the feedback. Merging! :clapper:

Pull-Request has been merged by jflory7