fedora-commops / fedora-happiness-packets

#238 Incorporate Fedmenu overlay on all pages for Local Development
Merged by jflory7. Opened by alishapapun.
fedora-commops/ alishapapun/fedora-happiness-packets fedmenu  into  master

Download 238.patch

This PR addresses #197 :)

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, needs testing, new change, type - frontend, type - summer coding

Hi @alishapapun! Thanks for working on this. :thumbsup:

This looks good, although I cannot see all of the sections of the menu. Is this an upstream bug or can we make fedmenu more responsive? For example, when I open the menu, I can't scroll down on my screen:

Screenshot of fedmenu flowing off-screen

Are you able to replicate this on smaller display sizes? (Btw, Responsive Design Mode in Firefox Web Dev Tools is useful for this!)

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
- Pull-request tagged with: needs changes
- Request assigned

1 new commit added

  • Fix bug

@jflory7, actually I had a look on the bug. The position property in custom.css for the position: absolute is not getting overwritten by the property in fedmenu.css. So, I tried to fix it at my end by declaring it as !important and it works as expected. Could you check it?
Edited by alishapapun

rebased onto a5eaa4e44ea3b509d7b6626317a6c633c3096a49

Metadata Update from @jflory7:
- Pull-request untagged with: needs changes

@alishapapun Awesomeeee! :raised_hands: Works as expected on my laptop now. It doesn't look fantastic on mobile devices, but it works (I think this is an upstream issue with fedmenu anyways).

Thanks for getting this done. Merging! :ocean:

Pull-Request has been merged by jflory7
Metadata
jflory7

PASSED new change type - frontend type - summer coding

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.