#24 apply Flock feedback
Merged by asamalik. Opened by asamalik.
Unknown source master

Download 24.patch
no initial comment

https://asamalik.fedorapeople.org/tmp/docs-modularity-pr24/modularity/making-modules/adding-new-modules/

rebased onto 9f5287b101f9f6a0f93e99367551214e106f8e3c

1 new commit added

  • one command for pkg + module repo

PRM->RPM

Can we redirect this to the standard RPM packaging guidelines? I don't really like recommending fedpkg import for anything other than the first creation of the package. Also, we don't have to keep this up to date if we just refer over to the standard RPM guidelines.

This should be updated to note that this is the section we deferred to above for when dealing with packages that don't match their module name. Also note that it can be skipped for dependencies if the module already exists.

Probably useful to note that --exception is passed here because module creation is permitted to skip the BZ step.

We should also open a bug to have it be set implicitly if --namespace == modules

"Note: this was done for you automatically if you did not pass --no-auto-module in the RPM step above"

satate->state

This is not true currently. That command just returns module-context right now. We need to change this to fedpkg module-build-info BUILD_ID which reports the correct tag.

Better would be to open a bug against fedpkg module-build-info to include the proper format for Bodhi inclusion in the output.

This is still referencing the dead modulemd repository.

We should probably omit this section, since v1 was already obsolete by the time that people started building modules for F28.

1 new commit added

  • fix the fedpkg request-* commands

1 new commit added

  • apply PR feedback

Thanks @sgallagh for the feedback! Again, I agree with everything you said, applied it, and rebuilt the preview.

Looks good to me!

Pull-Request has been merged by asamalik

Metadata