Fixes : https://pagure.io/fedora-hubs/issue/114 Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
did you do the changes manually or using something like autopep8?
I edited all the changes manually, as I have more control over editing code than automated tool. :D
I would keep this file as it was, I know it's not valid pep8 but these lines are not really comments more code commented out
This looks bad, the second part isn't a comment, it's the end of the URL, I'd keep it the way it was
This seems odd, pep8 complained about it?
I would keep this part the way it was, the code is incomplete and the # may just go away
#
Same here, I'd keep the lines as they were
And here again :)
At least for now :)
If the line is too long I'd split it after the string rather than in the middle of it
Tried putting the entire string in a new line with 4 spaces indentation?
Let's keep this as it was for now
I'd prefer the cut right after the url_for(, keeping all the args in the same row
url_for(
Let's keep this
And this
The closing bracket here should be at the same level as the return iirc
return
You could make it 1 assignment instead of three using \
\
I much prefer the older structure
Same as above
Just cut the line after the ( to avoid making more variables
(
Let's cut after the (
same as above
Do all the args fit in one line?
Let's keep these as they were
Thanks for looking into this, there are quite a few places where I would keep the code as it is because hubs is very much still WIP and therefore there are places where I don't care about pep8 and more about giving and idea of what we want to do there in the future.
I think I have indicated them all in the PR :)
Yes, It's better the way it was or we can add a line or two comment above about the URL.
rebased
@pingou @sayanchowdhury check now.
All good to me :)
But we need to rebase the PR before we merge it :)
:thumbsup: for me
Thanks :)
Pull-Request has been merged by pingou
Fixes : https://pagure.io/fedora-hubs/issue/114
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com