fedora-hubs

#197 Adding more unittests
Merged by skrzepto. Opened by skrzepto.
skrzepto/fedora-hubs unittest  into  unittest

Download 197.patch

fixing skipped tests so they pass and added test for /hub/add test

adding post tests for hub/add/ widget

added hubs edit post with valid minimum valid data

working on hubs edit widget testing Should be at 64% coverage

I may need to remove the changes in test_hub.py since atelic added them in his pr

rebased

rebased

Removed my changes from test_hub.py the PR can now be reviewed.

Minor: we probably should be consistent on whether we use double or single-quoted strings.

One minor note but looks good:

TOTAL 1457 519 64%

Ran 56 tests in 10.064s

OK (SKIP=5)

I think it depends on the situation but i agree this should be changed to single quote. Will push update soon

rebased

Additional note, it doesn't pass pep8 because of lines are too long but 2 out of the 4 strings are 81 chars and it doesn't make sense to split it unless someone has a suggestion that would make it pretty

IMO the 81 and 93 char lines are fine. It would probably make readability worse to change.

So :thumbsup: from me

that was the same thought i had thanks

Pull-Request has been merged by skrzepto
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.