PR#199: Fixing model relation ship -

when running delete-user.py with the hubs section commented out. When I enter user: decause to delete. From the db I see that the users table and associations table is affected and the hub is still around like predicted
This is with user already deleted. When I uncomment the hubs section from delete-user.py and enter user: decause to delete hub. The db hub row is gone and all its widgets are also all deleted.
With user still in db. From the db widgets, hubs. Association is missing the rows with decause in it but decause is still found in the users table just like we want

Regarding issue #195 the widget is successfully deleted while the user, hub, and sibling widgets still stay intact

:thumbsup: for me

Might be cool to add tests for this at one point, but I guess that's in #198 no?

i'll write some tests for it. There's not much in 198 that tests this modification.

Edited Jun 21, 2016 by skrzepto

Is it okay to wait for the unittest branch to merge in to the develop branch so I could borrow its test.class

Is it okay to wait for the unittest branch to merge in to the develop branch so I could borrow its test.class

Sure, on the contrary :)

Blocked by: PR#198

I have unittests locally that extensively test the models and then I'll add more tests for the route

Edited Jun 22, 2016 by skrzepto

rebased

Jun 23, 2016

Nice and clean tests, :thumbsup: for me

Pull-Request has been merged by skrzepto

Jun 23, 2016

Just a wording, we're checking that the association is removed :)

As in, if it is not, it's bug :)

yes when the hub is removed I expect the association to get removed as well, if not like you said its a bug :)

Assignee

None

Tags

No Tags