fedora-hubs

#216 Add: ellipsizing of group owners
Merged by atelic. Opened by atelic.
atelic/fedora-hubs feature/ellipsizing  into  develop

Download 216.patch

Changes

  • Sort top owners by oldest
  • View all link which opens modal to show all owners in alphabetical order
  • Add a global CSS rule for avatar size

Images

Refs

Issues #161 and partially #173.

The reason it doesn't fully fulfill #173 is because it doesn't implement an "auto-ellipsizing" feature. I am not sure how this would work since each widget is different with the markup that would be ellipsized as well as which part of the widget would be growing and taking up screen space. For now this implements a model for later widgets to consistently follow if needed.

rebased

Looks good to me with two small comments:

What about adding:

-  <h6>group owners</h6>
+  <h6>group owners ({{ owners|length }})</h6>

Also, maybe the avatar in the modal could be made a little smaller, what do you think?
Edited by pingou

I've added the number of owners. How much smaller were you thinking for the avatars? Same as the rest of the app?

How's this?
Edited by atelic

Is there a possibility you could add a margin from the top most avatar from the line? 10px?
Edited by skrzepto

How's this?

LGTM eventually with the margin mentioned by @skrzepto (sorry for the typo)

Edited by pingou

@skrzepto @pingou Fixed the spacing: http://i.imgur.com/fPrC50X.png

2 new commits added

  • Global rule for avatar size
  • Basic ellipsizing of group owners

@atelic Much better :)

Looks much better but I wonder if it won't be too much (for example for hubs with dozens of owners).

Anyway :thumbsup: for me and we can re-visit/adjust once the cloud instance is up to date w/ this PR and data :)

Pull-Request has been merged by atelic
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.