PR#218: Allow configuring the number of meeting shown in the meetings widget - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

fedora-hubs

#218 Allow configuring the number of meeting shown in the meetings widget

Merged Jul 20, 2016 by pingou. Opened Jul 18, 2016 by pingou.

pingou/fedora-hubs n_meetings into develop

Download 218.patch

no initial comment

atelic commented Jul 18, 2016

Won't the integer validator return this value?

pingou commented Jul 18, 2016

I thought but from testing it seems not :(

atelic commented Jul 18, 2016

Weird :/

atelic commented Jul 18, 2016

Confirmed it works locally. LGTM :thumbsup:

pingou commented Jul 19, 2016

Ok I found the right way to do this (w/ the validators working as expected and all)

2 new commits added

Always display the meetings widget, even if there are no coming meetings
Let the validator return the validated value and use it when editing a widget

Jul 19, 2016

rebased

Jul 20, 2016

pingou commented Jul 20, 2016

Rebased and updated :)

atelic commented Jul 20, 2016

:thumbsup: just needs another rebase :) HEAD is moving fast

rebased

Jul 20, 2016

Pull-Request has been merged by pingou

Jul 20, 2016

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.