fedora-hubs

#222 Adding more unittests
Merged by skrzepto. Opened by skrzepto.
skrzepto/fedora-hubs fixing-unittest  into  develop

Download 222.patch

Fixing some old unittests and adding new ones for the new library widget. Also I modified widget_source function since I can crash it if the file doesn't exist.

I'm still writing more but thought this would be a good spot to get a pull request reviewed.

rebased

I run my tests with

  PYTHONPATH=. nosetests --with-coverage --cover-erase --cover-package=hubs --cover-html

For some reason one of the tests are failing for me

FAIL: test_data_simple (hubs.tests.test_widgets.test_fedmsgstats.TestFedmsgStats)

On atelic machine it works fine, can someone confirm if its just an isolated incident

:thumbsup:

Why will this crash without a url? It looks like it should default to None

Is this still needed?

no its not, I can delete it

For some reason when it was in jsonify it was erroring can't split string. Also, when you add the library widget it won't let you add the widget if you dont add a single link

Gotcha, makes sense then.

1 new commit added

  • on some machines getting data for calendars doesnt always work and crashes test

rebased

Pull-Request has been merged by skrzepto
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.