fedora-hubs

#309 Use tox to run the tests
Merged by abompard. Opened by abompard.
abompard/fedora-hubs setup-tox  into  develop

Download 309.patch

Tox is a very nice test runner that will execute the tests on different versions of Python. This way, we can make sure that no Python3-incompatible change is introduced.

I have also set up the configuration to run Flake8, but it is not enabled by default yet, since it currently reports a lot of errors (most of which can be safely ignored).

I didn't even know you could have a gitignore in subdirectories like this.

Yes! I was just thinking about setting up tox.

One thing I like to do is add a unit test that shells out to flake8 and add a list of paths for it to check. That way you can slowly PEP8 the codebase and not regress. I can make a PR with that if that sounds good to you.

This looks good to me.

Did you see that my tox.ini has a flake8 runner? Were you thinking of something else?
Anyhow, I'll merge this one, we can add flake8 support later.
I like how we're on the same page, @jcline :-)

Pull-Request has been merged by abompard

I did, and now that I think about it this will achieve the same thing in a neater way.

This is what I tend to do. I really should just be using tox the way you have here :smile:

Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.