PR#334: Improve the Alembic config -

fedora-hubs

#334 Improve the Alembic config

Merged Mar 7, 2017 by sayanchowdhury. Opened Mar 4, 2017 by abompard.

abompard/fedora-hubs alembic into develop

abompard commented Mar 4, 2017

This changeset moves the Alembic config inside the hubs package, because it must be installed on the target system if we want admins to be able to upgrade their databases.

It also tweaks the env.py script to read the database configuration and metadata from hubs & fedmsg directly.

@jcline , you may be interested in this PR since you wrote the first config.

rebased

Mar 4, 2017

jcline commented Mar 6, 2017

Do we want to include the ansible role? I wrote it with development in mind and I can't think how people would use this after installing the Python package.

jcline commented Mar 6, 2017

@abompard thanks for this, it makes a lot of sense. Since I don't really have much experience with Alembic I followed what I saw in other Fedora projects, but including it inside the package seems way better. I guess the other projects rely on the specfile to install it somewhere and don't really work as Python packages.

I only had one question, but it doesn't hurt anything to distribute the Ansible stuff so I'm fine with it being included if you want that. Whatever you choose I don't think I need to re-review this.

sayanchowdhury commented Mar 7, 2017

+1 we don't need to include the ansible roles.

sayanchowdhury commented Mar 7, 2017

Why do we need to change the name from alembic to migrations?

sayanchowdhury commented Mar 7, 2017

alembic.ini is in the project root so we can remove hubs/

sayanchowdhury commented Mar 7, 2017

Ok, I see that the file got moved into the hubs/

Pull-Request has been merged by sayanchowdhury

Mar 7, 2017