PR#347: Rebase our HTML/CSS on fedora-bootstrap 1.0.3 -

fedora-hubs

#347 Rebase our HTML/CSS on fedora-bootstrap 1.0.3

Merged Jun 1, 2017 by abompard. Opened May 17, 2017 by abompard.

abompard/fedora-hubs refactor-html into develop

abompard commented May 17, 2017

The version of fedora-bootstrap that we were carrying in the code was a very old one, and the documentation on https://v4-alpha.getbootstrap.com/ did not entirely apply, which made writing HTML/CSS in Hubs very error prone.
This PR rebases on our latest released version of fedora-bootstrap, which is pretty current with the online documentation (I did not find a difference yet).
Of course I also rebased the existing CSS classes throughout the code.

I've also refactored the HTML templates a bit to avoid unnecessary duplication.

The last commit also avoids a deprecation warning in React about PropTypes

sayanchowdhury commented May 17, 2017

Thanks for this. Totally prefer float-right

sayanchowdhury commented May 17, 2017

PropTypes is moved out of the core React?

abompard commented May 18, 2017

Yeah, PropTypes has its own library now, you can see the deprecation warning in the browser console.

sayanchowdhury commented Jun 1, 2017

Good to merge :thumbsup:

Pull-Request has been merged by abompard

Jun 1, 2017